This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: 3rd PATCH to pre-select languages to be built

To: manfred at s-direktnet dot de
Subject: Re: 3rd PATCH to pre-select languages to be built
From: Alexandre Oliva <oliva at dcc dot unicamp dot br>
Date: 26 Oct 1998 04:02:49 -200
Cc: Manfred dot Hollstein at ks dot sel dot alcatel dot de, law at cygnus dot com, egcs-patches at cygnus dot com, burley at gnu dot org, jbuck at synopsys dot com, pfeifer at dbai dot tuwien dot ac dot at, rearnsha at arm dot com
References: <13844.62616.64201.274193@saturn.hollstein.net> <11646.908431264@hurl.cygnus.com> <13872.18354.512192.830071@slsvhmt>

Manfred Hollstein <manfred@s-direktnet.de> writes:

> +if test "${enable_languages+set}" != set; then

Please make that:

> +if test x"${enable_languages+set}" != xset; then

This avoids ugly errors if enable_languages happens to be set to
something that starts with `-' or `!'.

Similarly for other tests.

WRT to the problem of empty Makefiles, how about using a trick similar
to the one that automake uses in order to create conditional blocks
within Makefiles.

Makefile.in could contain, for example:

all: # just to make sure it is a valid target
@CONDITIONAL@all: ...
	...

Then @CONDITIONAL@ could be AC_SUBSTed as an empty string or as
`disabled-'.  The same would apply to install, install-info and other
targets I may have forgotten about

-- 
Alexandre Oliva
mailto:oliva@dcc.unicamp.br mailto:oliva@gnu.org mailto:aoliva@acm.org
http://www.dcc.unicamp.br/~oliva
Universidade Estadual de Campinas, SP, Brasil

Follow-Ups:
- Re: 3rd PATCH to pre-select languages to be built
  - From: Manfred Hollstein

References:
- 2nd PATCH to pre-select languages to be build
  - From: Manfred Hollstein
- Re: 2nd PATCH to pre-select languages to be build
  - From: Jeffrey A Law
- 3rd PATCH to pre-select languages to be built
  - From: Manfred Hollstein

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]