This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: warning patches part 1/2
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: warning patches part 1/2
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Tue, 13 Oct 1998 09:43:05 -0600
- cc: egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <199810121601.MAA19030@caip.rutgers.edu>you write:
>
> Mon Oct 12 10:29:55 1998 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> * c-decl.c (c_decode_option): Ifndef USE_CPPLIB, mark parameter
> `argc' with ATTRIBUTE_UNUSED.
This is rather silly and doesn't help readability in any way. Can we just
mark it as unused unconditionally instead of farting around with trying to
determine exactly under what set of macro defitions these things may be unused?
I don't think conditionalizing that is worth the pain.
Similarly for other cases where you've conditionally used ATTRIBUTE_UNUSED.
The rest of the changes look OK to me.
jeff