Re: Need someone to look at a regression

["Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>]

 > From: Jeffrey A Law <law@hurl.cygnus.com>
 > 
 > Kaveh -- I think you had a patch to kill the warnings in fp-bit.c
 > which originally inspired this debate.  Consider them approved.
 > jeff

	Heh, been busy and I'm about 2000 messages behind on reading
the various egcs lists, good thing you cc'ed me directly. :-)

	I found the patch in the archive, if you're interested its
http://www.cygnus.com/ml/egcs-patches/1998-Jun/0490.html.  Specifically,
the entry:

 > * config/fp-bit.c (SFtype, DFtype): Make type `int' explicit.

is the part under question.


	I went over this debate thread in the archives and the
messages seemed to indicate that the actual type used doesn't matter (?)

	Anyway in trying to piece together what's going on, I looked in
libgcc2.c and noticed that it avoids the warning by doing:

 > typedef float SFtype __attribute__ ((mode (SF)));
 > typedef float DFtype __attribute__ ((mode (DF)));

	So at least to be consistent, I'd like to put 'typedef float'
into fp-bit.c instead of 'typedef int'.


	Sadly, I am unable to test either of the explicit types now
because in trying to bootstrap the trunk (checked out earlier today) on
the platform where this all happened (powerpc-ibm-aix4.1.4.0) I'm
getting major bootstrap problems. 


 > ./xgcc -B./ -DIN_GCC -W -Wall -g -O2 -mminimal-toc -I./include
 > 	-I. -I. -I./config -c ./objc/hash.c -o objc/hash.o
 > In file included from ./objc/hash.c:27:
 > include/assert.h:318: warning: unrecognized text at end of #line
 > include/assert.h:341: warning: integer constant out of range
 > include/assert.h:341: warning: decimal constant is so large that it is
 > 	unsigned
 > include/assert.h:-1164968173: warning: unrecognized text at end of #line
 > include/assert.h:-1164968169: warning: integer constant out of range
 > include/assert.h:-1164968169: warning: decimal constant is so large
 > 	that it is unsigned
 > ./objc/hash.c:-1164968198: warning: unrecognized text at end of #line
 > In file included from ./objc/hash.c:-1164968195,
 >                  from ./objc/hash.c:27:
 > [etc]
 > ./objc/hash.c:-2059423448: warning: integer constant out of range
 > ./objc/hash.c:-2059423448: warning: decimal constant is so large
 > 	that it is unsigned
 > ./objc/hash.c:-2059423448: warning: large integer implicitly truncated
 > 	to unsigned type
 > make[2]: *** [objc/hash.o] Error 1

	Those are some seriously wacky line numbers. :-)

I'd like to hold off on inserting any patch until I can get a clean
bootstrap on a system which uses fp-bit.c. 

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Icon CMT Corp.