This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH to rs6000.md, comments?


	I don't want to remove save_stack_function and
restore_stack_function from rs6000.md.  This is a prototyping problem, not
a problem with the machine description.  The patterns in rs6000.md are
useful because they document some magic going on behind the scenes.

	As far as the CONSTANT_P_RTX changes, Richard already commented on
the unnecessary "return 0;" cases.  I personally do not like the style of
most of the changes.  The CONSTANT_P_RTX test should be or'ed into the
other tests for consistency, not a separate "if ... return 1".

	Richard: my comment about movdi as well was referring to 64-bit
mode in which case DImode is an integer.  movdi *does* need to be changes
as well symmetrically with movsi.

	Jeff: Do you want me to redo all of this?  Integrate it into the
egcs-1.1 release branch as well?

David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]