Re: PATCH: OpenServer and GNU as.

[Robert Lipe <robertl at dgii dot com>]

Jeffrey A Law wrote:
> 
>   In message <19980630222258.A2268@dgii.com>you write:
>   > 
>   > The following patch adds support for --with-gnu-as to OpenServer.  This
>   > 
>   >         * install.texi (sco3.2v5): Document new --with-gnu-as flag.

I have some additional doc changes in here that aren't part of this patch.

>   >         * config/i386/sco5.h (JUMP_TABLES_IN_TEXT_SECTION): Defined as
>   >         in other targets.
>   >         (USE_GAS): Conditionalize away native assembler usage.
>   >         * config/i386/sco5gas.h: New file.
>   >         * config/i386/t-sco5gas: New file.
>   >         * configure.in (ix86-sco3.2v5*): Use new files if --with-gnu-as
> Mostly OK.
> 
>   > Index: config/i386/sco5gas.h
> This file seems to exist only to define USE_GAS, then include sco5.h.

Correct.

> Instead of including sco5.h, you should just list sco5.h as another
> target file in the tm_file list.
> 
> ie
> 
> 	tm_file="i386/sco5gas.h i386/sco5.h"

Looks good to me.   I'll do that.

> This is the preferred way to handle this kind of situation.  And
> if we ever clean up gas.h you would add it to the tm file list and
> you'd get the auto jump alignment stuff and whatever other interesting
> gas bits might be around :-)

I think I already get the auto alignment if built --with-gnu-as becuase
configure/autoconf tests for it.

$ diff gas/gcc/auto-host.h negcs/gcc
17c17
< #define HAVE_GAS_MAX_SKIP_P2ALIGN 1
---
> /* #undef HAVE_GAS_MAX_SKIP_P2ALIGN */
69,77d68

> Consider it approved with the minor tweak.

I'll crank the commit today.

Thanx,
RJL