[Bug translation/84303] New: Styled quotes in error message may be inappropriate

["fmarchal at perso dot be" <gcc-bugzilla at gcc dot gnu dot org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84303

            Bug ID: 84303
           Summary: Styled quotes in error message may be inappropriate
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: translation
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fmarchal at perso dot be
  Target Milestone: ---

In config/rs6000/rs6000.c, one can find the following code:

          if (error_p)
            {
              const char *eprefix, *esuffix;

              ret = false;
              if (attr_p)
                {
                  eprefix = "__attribute__((__target__(";
                  esuffix = ")))";
                }
              else
                {
                  eprefix = "#pragma GCC target ";
                  esuffix = "";
                }

              if (cpu_opt)
                error ("invalid cpu %qs for %s%qs%s", cpu_opt, eprefix,
                       q, esuffix);
              else if (not_valid_p)
                error ("%s%qs%s is not allowed", eprefix, q, esuffix);
              else
                error ("%s%qs%s is invalid", eprefix, q, esuffix);
            }
        }

The "%s%qs%s" part used to be "%s\"%s\"%s". I think the old syntax was better
because it matches what the source code looks like. %qs is equivalent to « %s »
in French.