This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug middle-end/78809] Inline strcmp with small constant strings


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78809

--- Comment #28 from Qing Zhao <qing.zhao at oracle dot com> ---
> 
> I don't think this is a good test.  Repeatedly calling strcmp with the same
> inputs is not something real code does, especially when the string matches
> exactly.  Why would it do that?  The consequence is that you are probably
> optimizing for a very unlikely scenario.  Instead you need to look at traces
> from real code to understand how strcmp is called in practice.  Nothing else
> will give you a defensible answer.

Please see the latest attachment to this bug, it addressed your above concerns.
let me know if you have more concerns with the new testing cases or any
concrete
suggestion to improve the testing case. 
The next step will do performance testing with SPEC2006 or SPEC2017 to further
decide the default threshold.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]