[Bug fortran/78822] [cleanup] replace static char buffers by std:string

["janus at gcc dot gnu.org" <gcc-bugzilla at gcc dot gnu dot org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78822

--- Comment #16 from janus at gcc dot gnu.org ---
(In reply to Jakub Jelinek from comment #15) 
> Some comments:

Thanks!


> 1) this still doesn't solve the translations issue in many places
> (gfc_compare_interfaces etc.);

True. I don't wanna open up too many building sites at once, therefore I'm
sticking with the status quo here. It seems there are several inconsistencies
in this area, so maybe we want a follow-up PR for that.


> 2) if in the different functions that return bool you always return true if
> you set *errmsg and return false if you don't set it (or vice versa), then
> you could
> change those functions to return const char * and in the caller test for ==
> NULL (meaning success) and != NULL (return value is the error string to emit
> and free afterwards.

Yes, might be a good idea.


> 3)
> +      *errmsg = build_message_string ("CONTIGUOUS attribute mismatch in "
>  		"function result");
> the formatting looks wrong, "function should be below "CONTIGUOUS.

Right. Will fix.