This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug middle-end/78501] [7 regression] SEGV in vrp_val_max


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78501

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Comment on attachment 40137
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40137
check precision of ptrdiff_type_node and lhs type is equal

Formatting is wrong.  && should not be at the end of line, and as the condition
doesn't fit on one line, each subcondition should be on a separate line.
Also, the outer {} look ugly.  Perhaps:
  case CFN_BUILT_IN_STRLEN:
    if (tree lhs = gimple_call_lhs (stmt))
      if (ptrdiff_type_node
          && TYPE_PRECISION (ptrdiff_type_node) == TYPE_PRECISION (TREE_TYPE
(lhs)))
        {
          ...
          return;
        }
    break;
?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]