This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug fortran/69554] [6 Regression] Multi-location diagnostics writes too many lines


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69554

--- Comment #11 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
(In reply to Manuel LÃpez-IbÃÃez from comment #7)
> Please take this as a humble general suggestion: Fortran maintainers should
> enforce during patch review that any new diagnostic has a corresponding
> testcase triggering it in the testsuite.

I think you are right, on general principles.  We usually try this.
You can get a lot of test cases testing for runtime errors, because
you can only test for a single error with each test case...

However, this would not have helped in this case.  The problem here
was that the testsuite is lenient enough to allow for random
junk to appear between two error messages (which is understandable,
given that we only want to check for the particular error messages,
and there is a lot of stuff in between), that nobody thought of this
particular case (it only came to light when I wanted to test a new
error message with two locations).

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]