This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug target/69012] gcc-6.0.0 internal compiler error building libgfortran for mips64el target


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69012

--- Comment #16 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
(In reply to Nick Clifton from comment #15)
> Hi Guys,
> 
>   I have checked in Bernd's patch as it also fixes PR 69129.  I think that
> this PR can also be closed now, although I am not sure if we need to add
> another testcase to gcc.target/mips.  (I added a testcase for pr69129...)
> 
> Cheers
>   Nick

Very nice test case.  Thanks!

I am still unsure, if we shouldn't also do something like this,
to prevent any remaining possibility for a further regression:

Index: gcc/config/mips/mips.c
===================================================================
--- gcc/config/mips/mips.c      (revision 231954)
+++ gcc/config/mips/mips.c      (working copy)
@@ -10321,6 +10321,10 @@ mips_compute_frame_info (void)
   HOST_WIDE_INT offset, size;
   unsigned int regno, i;

+  /* Don't change the frame info after reload completed.  */
+  if (reload_completed)
+    return;
+
   /* Set this function's interrupt properties.  */
   if (mips_interrupt_type_p (TREE_TYPE (current_function_decl)))
     {

(I proposed that, but Richard S. raised objections against it)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]