This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug c/57653] filename information discarded when using -imacros


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57653

Manuel LÃpez-IbÃÃez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm28 at gcc dot gnu.org

--- Comment #20 from Manuel LÃpez-IbÃÃez <manu at gcc dot gnu.org> ---
(In reply to Allan McRae from comment #19)
> That patch works.  With -imacros foo.h:
> 
> LC_ENTER  foo.c
> LC_RENAME <command-line>
> LC_ENTER  foo.h
> LC_LEAVE  0x0
> LC_ENTER  /usr/include/stdc-predef.h
> LC_LEAVE  0x0
> LC_RENAME foo.c
> <- correct output
> LC_LEAVE  0x0
> 
> All other combinations of -include/-imacros/-ffreestanding/no foo.h  all are
> unchanged as expected.

Great! I am certainly too busy at the moment to go through all the steps of the
contribution process for this. The patch needs to be fully bootstrapped with
the latest trunk, an appropriate testcase needs to be created, plus run the
full regression testsuite and compare the results with the regression results
of the unpatched trunk and check that no new failures appear. Then, it has to
be submitted to gcc-patches with a GNU Changelog.

If you are really interested in fixing this, you should just take the lead.
Feel free to modify the patch as you need. The patch is anyway too small to
require any kind of legal assignment, but if they ask for it, you can always
say I wrote it. I have an assignment in place with the FSF.

When submitting to gcc-patches, CC jsm28@gcc.gnu.org. You can also see in the
svn log or svn blame who wrote the -imacro code and CC him/her as well. (You
can also CC me).

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]