[Bug fortran/46244] gfc_compare_derived_types is buggy

["paul.richard.thomas at gmail dot com" <gcc-bugzilla at gcc dot gnu dot org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46244

--- Comment #16 from paul.richard.thomas at gmail dot com <paul.richard.thomas at gmail dot com> 2011-02-21 08:25:51 UTC ---
Dear Mikael,

....snip....

> Actually none of the gfc_compare_type/gfc_TK_compatible changes are absolutely
> necessary to fix this bug. It is just I found it odd that gfc_compare_type was
> calling gfc_type_compatible (compatible types are not necessary
> equal/equivalent), so I changed it so that gfc_type_compatible calls
> gfc_compare_type instead. And then the new gfc_TK_compatible function to not
> upset the testsuite.
>
> Maybe I just don't understand what "compare types" means. :-(

....snip....

> Hem, yes, who wrote this? ( I hope it's not me ;-) ).

There have been a number of contributors over the years.  Therein lies
the problem.  Quick fix has been piled on quick fix and the result is
something of a mess.

"It is just I found it odd that gfc_compare_type was calling
gfc_type_compatible (compatible types are not necessary
equal/equivalent), so I changed it so that gfc_type_compatible calls
gfc_compare_type instead."

That was indeed very peculiar.  I know who the culprit was but I am
not telling :-)

If you have time to put this right I, for one, would be very pleased.

A

Paul