This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug target/36502] i386/darwin generates unnecessary stack ops in every function



------- Comment #26 from hjl dot tools at gmail dot com  2010-08-31 20:30 -------
(In reply to comment #15)
> Created an attachment (id=21607)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21607&action=view) [edit]
> rely on PREFERRED_STACK_BOUNDARY_DEFAULT and MAIN_STACK_BOUNDARY
> 

This is wrong:

-/* Since we'll never want a stack boundary less aligned than 128 bits
-   we need the extra work here otherwise bits of gcc get very grumpy
-   when we ask for lower alignment.  We could just reject values less
-   than 128 bits for Darwin, but it's easier to up the alignment if
-   it's below the minimum.  */
-#undef PREFERRED_STACK_BOUNDARY
-#define PREFERRED_STACK_BOUNDARY                       \
-  MAX (STACK_BOUNDARY, ix86_preferred_stack_boundary)
-

You must keep it and replace STACK_BOUNDARY with 128.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36502


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]