This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug c++/14808] [3.4/3.5 Regression] [win32] Undefined results with virtual base classes


------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-04-07 22:11 -------
The patch is OK for the mainline.

On the 3.4.0 branch, it is *not* OK.

Instead, please submit an uglier, but safer, patch that tests for __CYGWIN__ and
__MINGW32__ in the same place where the mainline patch checks the new target macro.

In other words:

  #if defined (ASM_OUTPUT_DEF) && !defined(__CYGWIN__) && !...
    alias version
  #else
    non-alias version
  #endif

Please attach that patch to the PR after testing.

I will then approve it for 3.4.0.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14808


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]