This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
code that could be improved
- From: Roland Illig <roland dot illig at gmx dot de>
- To: bug-gcc at gnu dot org
- Date: Tue, 02 Mar 2004 00:55:41 +0100
- Subject: code that could be improved
Hi,
I'm currently translating gcc-3.4-b20040206 into German. Here is a list
of things I don't like in the current code:
- various quoting techniques: `foo', 'bar', "baz".
=> please use `foo' consistently
- inconsistent usage of `member' and `field'
=> does a struct have `field's or `member's?
=> What about unions?
=> What about C++ classes?
- some message patterns could be simplified for translation.
for example "invalid %%f value" and "invalid %%H value" will
always be translated with just replacing "f" by "H", won't it?
So the code should look like
sprintf(foo, "invalid %%%c value", 'f');
But there are also things I was happy to see:
- the new format for command line options using "-switch\tdescription"
I'll continue this list while translating further.
Roland