This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: c/9072: -Wconversion should be split into two distinct flags
- From: Wolfgang Bangerth <bangerth at ticam dot utexas dot edu>
- To: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>
- Cc: 128950 at bugs dot debian dot org, <agthorr at barsoom dot org>, <gcc-bugs at gcc dot gnu dot org>, <segher at koffie dot nl>, <gcc-gnats at gcc dot gnu dot org>
- Date: Mon, 3 Feb 2003 10:31:41 -0600 (CST)
- Subject: Re: c/9072: -Wconversion should be split into two distinct flags
On Mon, 3 Feb 2003, Joseph S. Myers wrote:
> > Has been analyzed. Patch is even in the audit trail, but
> > seems to have become stuck in gcc's patch acceptance machinery...
>
> The patch isn't even one suitable for review, as it lacks testcases. It
> is established procedure [0] that patches failing to follow the standards
> adequately get ignored.
Sorry, don't flame me :-) I am just trying to find ways to get patch
submitters and potential reviewers together.
The bug database is full with reports that have patches attached. If
nobody with the ability to judge things takes a look at them, then they
will remain open forever. I'm just trying to spark discussion on them.
Every once in a while I succeed to get a patch into CVS this way. I think
that's better than just letting them sleep.
> [0] This is very bad procedure; ignoring patches rather than explaining
> what is wrong is far too likely to lose potential contributors.
Exactly. If there's someone with little knowledge of gcc processes who
manages to find a patch that then never gets any attention, he's not
likely to try again next time. If he does get feedback, and be it only
that the patch is basically that it is ok but a Changelog entry missing
and that the ChangeLog format is described at XYZ, then that'll motivate
people.
I do understand why this is so, but we're doing badly in this field!
Regards
Wolfgang
PS: Segher - I think the idea of this PR is right, and I would certainly
appreciate if you could submit a patch! Thanks!
-------------------------------------------------------------------------
Wolfgang Bangerth email: bangerth@ticam.utexas.edu
www: http://www.ticam.utexas.edu/~bangerth/