This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: c/3952: comptypes() segfaults
- To: gcc-bugs at gcc dot gnu dot org, gcc-prs at gcc dot gnu dot org, nobody at gcc dot gnu dot org, robertlipe at usa dot net
- Subject: Re: c/3952: comptypes() segfaults
- From: sirl at gcc dot gnu dot org
- Date: 21 Aug 2001 21:49:59 -0000
Synopsis: comptypes() segfaults
State-Changed-From-To: open->analyzed
State-Changed-By: sirl
State-Changed-When: Tue Aug 21 14:49:58 2001
State-Changed-Why:
I just saw a similar crash with gcc-3.0.1 (release) and it seems that this is just a missing null-pointer check. AFAICS TYPE_MAX_VALUE can legally be zero.
I think the fix is sth similar to this:
/* Sizes must match unless one is missing or variable. */
if (d1 == 0 || d2 == 0 || d1 == d2
|| ! TYPE_MAX_VALUE (d1) || ! TYPE_MAX_VALUE (d2)
|| TREE_CODE (TYPE_MIN_VALUE (d1)) != INTEGER_CST
|| TREE_CODE (TYPE_MIN_VALUE (d2)) != INTEGER_CST
|| TREE_CODE (TYPE_MAX_VALUE (d1)) != INTEGER_CST
|| TREE_CODE (TYPE_MAX_VALUE (d2)) != INTEGER_CST)
break;
I'm running a bootstrap .on powerpc-linux-gnu now. Robert, can you check if the fix above works for you too?
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view&pr=3952&database=gcc