Re: (C++) Incorrect new warning?

[Nathan Sidwell <nathan at codesourcery dot com>]

Gerald Pfeifer wrote:
>   x.cc: In function `int main ()':
>   x.cc:8: warning: passing negative value `-1' for argument 1 of
>   x.cc:8: warning: `pair<_T1, _T2>::pair (const _T1 &, const _T2 &) [with
>   x.cc:8: warning: _T1 = int, _T2 = unsigned char]'
I've committed the attached obvious fix, and testcase so this can never
happen again (TM).

nathan
-- 
Dr Nathan Sidwell   ::   http://www.codesourcery.com   ::   CodeSourcery LLC
         'But that's a lie.' - 'Yes it is. What's your point?'
nathan@codesourcery.com : http://www.cs.bris.ac.uk/~nathan/ : nathan@acm.org
2000-03-06  Nathan Sidwell  <nathan@codesourcery.com>

	* typeck.c (dubious_conversion_warnings): Look through
	REFERENCE_TYPE.

Index: cp/typeck.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/cp/typeck.c,v
retrieving revision 1.257
diff -c -3 -p -r1.257 typeck.c
*** typeck.c	2000/03/05 10:22:16	1.257
--- typeck.c	2000/03/06 15:42:37
*************** dubious_conversion_warnings (type, expr,
*** 6433,6438 ****
--- 6433,6441 ----
       tree fndecl;
       int parmnum;
  {
+   if (TREE_CODE (type) == REFERENCE_TYPE)
+     type = TREE_TYPE (type);
+   
    /* Issue warnings about peculiar, but legal, uses of NULL.  */
    if (ARITHMETIC_TYPE_P (type) && expr == null_node)
      {
2000-03-06  Nathan Sidwell  <nathan@codesourcery.com>

	* g++.old-deja/g++.warn/impint2.C: New test.	

Index: testsuite/g++.old-deja/g++.warn/impint2.C
===================================================================
RCS file: impint2.C
diff -N impint2.C
*** /dev/null	Tue May  5 13:32:27 1998
--- impint2.C	Mon Mar  6 07:46:08 2000
***************
*** 0 ****
--- 1,68 ----
+ // Build don't link:
+ 
+ // Copyright (C) 2000 Free Software Foundation, Inc.
+ // Contributed by Nathan Sidwell 6 Mar 2000 <nathan@codesourcery.com>
+ 
+ // initialization to 'int' from to 'double' We expect consistent warnings
+ // whenever a float is implicitly truncated to int, make sure references
+ // don't confuse us, as Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> found out.
+ 
+ struct X
+ {
+   X (int const &);
+   X (int const &, int const &);
+ };
+ 
+ void foo (int const &);       // WARNING - in passing
+ void wibble (int const &);
+ void wibble (int const &, int const &);
+ void punk (int const & = 3.5f);        // WARNING - in passing
+ void rock ();
+ void rock (int const &, int  const & = 3.5f);       // WARNING - in passing
+ 
+ void fn ()
+ {
+   X x2(3.5f);       // WARNING - float to int
+   X x4(1, 3.5f);    // WARNING - float to int
+   X x6(3.5f, 1);    // WARNING - float to int
+ 
+   X y2 = 3.5f;      // WARNING - float to int
+ 
+   int j2 (3.5f);    // WARNING - float to int
+ 
+   int k2 = 3.5f;    // WARNING - float to int
+   
+   j2 = 3.5f;        // WARNING - float to int
+   
+   foo (3.5f);       // WARNING - float to int
+   
+   wibble (3.5f);    // WARNING - float to int
+   wibble (1, 3.5f); // WARNING - float to int
+   wibble (3.5f, 1); // WARNING - float to int
+   
+   punk ();          // WARNING - float to int
+   rock (1);         // WARNING - float to int
+ }
+ 
+ // and make sure we really know when something's unsigned
+ void foo ()
+ {
+   X x2(-1);
+   X x4(1, -1);
+   X x6(-1, 1);
+ 
+   X y2 = -1;
+ 
+   int j2 (-1);
+ 
+   int k2 = -1;
+   
+   j2 = -1;
+   
+   foo (-1);
+   
+   wibble (-1);   
+   wibble (1, -1);
+   wibble (-1, 1);
+   
+ }