Re: aggressive fixincludes

[korbb at sourceware dot cygnus dot com]

Raja R Harinath wrote:
> 
> BTW, this causes another problem.  AFAI can make out, even though the
> old fixinc.ix86-pc-linux-gnu script was folded into the generic fixinc
> framework, it isn't working.  The 'inclhack.sh' file has the following:
> 
>     # Skip unreadable files, symlinks to directories and glibc files
>     if test ! -r "${file}" || test -d "${file}/." \
>        || fgrep 'This file is part of the GNU C Library' "${file}" \
>             > /dev/null 2>&1; then
>       continue
>     fi

Dinkleberry, I suppose.  It was in the original on the assumption
that the GNU folk would not make a mistake.  Wrong.  I'll fix it
from both the binary and the shell script.

>     #
>     # Fix  10:  Aab_Fd_Zero_Glibc_2_0
>     #
>     case "${file}" in ./selectbits.h )
>     if ( test -n "`egrep 'i[34567]86-*-linux-gnu*' ${file}`"
>        ) > /dev/null 2>&1 ; then
>     echo "aab_fd_zero_glibc_2_0 replacing file ${file}" >&2
>     cat > ${DESTFILE} << '_EOF_'
>     [snip]
> 
> [[...]] the test -n 'egrep..' seems bogus.
> That file doesn't have that string on my
> machine, but it still needs the fix listed.

Yep.  Looks like a bug to me.  That should read more along
the lines of:

  case ${target} in
  i[34567]86-*-linux-gnu* )
     echo "aab_fd_zero_glibc_2_0 replacing file ${file}" >&2
     cat > ${DESTFILE} << '_EOF_'
     [[...]]