This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to rs6000.md, comments?
- To: law at cygnus dot com, Jeffrey A Law <law at cygnus dot com>
- Subject: Re: PATCH to rs6000.md, comments?
- From: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>
- Date: Thu, 16 Jul 1998 01:31:12 +0200
- Cc: egcs-bugs at cygnus dot com, egcs-patches at cygnus dot com
- References: <21601.900542719@hurl.cygnus.com>
Am Thu, 16 Jul 1998 schrieb Jeffrey A Law:
>In message <199807151813.LAA28352@cygnus.com>you write:
> > Hi,
> >
> > this patch should fix (not tested yet) two warnings in explow.c, because
> > the prototypes for gen_save_stack_function and gen_restore_stack_function
> > don't match. The comment in rs6000.md suggests that these two are not
> > used/needed anyway and thus it should be possible to remove them in
> > presence of the HAVE_* macros now.
> > Is this the correct solution?
>I'll let David comment on the patch itself.
OK.
> > BTW, what's the status of the CONSTANT_P_RTX mods for the rs6000 backend?
>I would recommend against folks spending time on this right now, our
>concentration should be on stabilizing for egcs-1.1, not adding new
>optimizations.
Uah, I don't agree!! First I don't think the CONSTANT_P_RTX is an optimization,
I thought it's simply different __builtin_constant handling. If this is not
fixed before 1.1, users will be flooded with the resulting warnings, which
additionally invalidate the whole testsuite! Something _has_ to be done about
this before 1.1!
BTW, I see new testcases are only added to the mainline now. Shouldn't the
testcase deadline moved nearer to the 1.1 release date? Especially for c++
testcases...
Franz.