This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: i386 code label alignment patch (version 2)
- To: Ian Lance Taylor <ian at cygnus dot com>
- Subject: Re: i386 code label alignment patch (version 2)
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Tue, 19 May 1998 00:52:47 -0600
- cc: john at feith dot com, egcs-bugs at cygnus dot com, wilson at cygnus dot com
- Reply-To: law at cygnus dot com
In message <199805182052.QAA29451@subrogation.cygnus.com>you write:
> I can change this to use feature tests if desired. It may been harder
> to reliably determine if a feature is available using feature tests
> instead of gas version numbers in some cases. Feature tests certainly
> make sense if supporting features that are expected to be implemented
> in the same fashion by more than one assembler vendor. At the moment
> I'm only concerned with taking advantage of newer gas specific features.
> It seems cleaner in this scenario to merely check GAS_MAJOR_VERSION and
> GAS_MINOR_VERSION.
>
> I think feature tests are always better than version number tests. I
> think version number tests are a last resort. That's because you
> don't actually care what version number you are using. You only care
> whether a particular feature works. You might be using some weird
> mutant gas which thinks that it's version 970813 or something (and
> believe me, there are plenty of such mutants out there).
Ian has raised an excellent point. I think we're better off with
a feature test.
jeff