This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: Implement C _FloatN, _FloatNx types [version 6]
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, James Greenhalgh <james dot greenhalgh at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Nick Clifton <nickc at redhat dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, David Edelsohn <dje dot gcc at gmail dot com>, Segher Boessenkool <segher at kernel dot crashing dot org>, Michael Meissner <meissner at linux dot vnet dot ibm dot com>, murphyp at linux dot vnet dot ibm dot com, nd at arm dot com, Per Bothner <per at bothner dot com>
- Date: Fri, 19 Aug 2016 13:21:01 -0400
- Subject: Re: Implement C _FloatN, _FloatNx types [version 6]
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.20.1606211202040.4526@digraph.polyomino.org.uk> <alpine.DEB.2.20.1606211738200.31330@digraph.polyomino.org.uk> <alpine.DEB.2.20.1606231418120.21240@digraph.polyomino.org.uk> <alpine.DEB.2.20.1606271720270.7438@digraph.polyomino.org.uk> <alpine.DEB.2.20.1607191347340.9265@digraph.polyomino.org.uk> <alpine.DEB.2.20.1607222158330.22448@digraph.polyomino.org.uk> <20160817154244.GA39270@arm.com> <alpine.DEB.2.20.1608171641000.7156@digraph.polyomino.org.uk> <alpine.DEB.2.20.1608172015080.27199@digraph.polyomino.org.uk> <CAFiYyc3xqcqJ1rK2X0rC+wwpx3akHbULVG1G47PRmtk4wTk=7A@mail.gmail.com> <alpine.DEB.2.20.1608191101110.30687@digraph.polyomino.org.uk> <CAFiYyc3r-TA2PNwsXSabtaKroYgRh0hjgRbe7u=wR949BetpXQ@mail.gmail.com> <alpine.DEB.2.20.1608191439230.21166@digraph.polyomino.org.uk> <1471621961.24300.24.camel@redhat.com> <alpine.DEB.2.20.1608191646360.6408@digraph.polyomino.org.uk>
On Fri, 2016-08-19 at 16:51 +0000, Joseph Myers wrote:
> On Fri, 19 Aug 2016, David Malcolm wrote:
>
> > Please could you take this opportunity to add some examples to the
> > header comment for that function, both for the common cases e.g.
> > "f",
> > and for the new suffixes; nothing in the patch body appears to
> > document
> > them. (ideally, referencing the standard).
> >
> > Also, it would be good to add some more comments to the function
> > body.
> > For example, in this hunk:
> >
> > - if (f + d + l + w + q > 1 || i > 1)
> > + if (f + d + l + w + q + fn + fnx > 1 || i > 1)
> >
> > should it read something like :
> > /* Reject duplicate suffixes, contradictory suffixes [...] */
> >
> > where "[...]" is something relating to fn + fnx, which I can't
> > figure
> > out in the absence of the standard you're referring to.
>
> How does this seem? I think
> <http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1945.pdf> was the
> last
> public draft of TS 18661-3 before publication.
Thanks - the comments make things much clearer.
[...snip...]