This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Chung-Lin Tang <cltang at codesourcery dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>, Thomas Schwinge <thomas at codesourcery dot com>
- Date: Tue, 9 Aug 2016 17:30:00 +0200
- Subject: Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE
- Authentication-results: sourceware.org; auth=none
- References: <2b4f59d5-be38-2814-27bb-73aa7ffb4b8f@codesourcery.com> <20160721111322.GE7387@tucnak.redhat.com> <25374818-5cac-ef7a-04a6-fb46f8cd1076@codesourcery.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jul 29, 2016 at 11:47:18PM +0800, Chung-Lin Tang wrote:
> On 2016/7/21 07:13 PM, Jakub Jelinek wrote:
> > Better put every && on a separate line if the whole if (...) doesn't fit
> > on a single line.
> >
> >> > + && !n->sym->attr.cray_pointer
> >> > + && !n->sym->attr.cray_pointee)
> > This is too ugly. I'd instead move the if after the cray pointer/pointee
> > tests, i.e.
> > if (n->sym->attr.cray_pointer)
> > gfc_error (...);
> > else if (n->sym->attr.cray_pointee)
> > gfc_error (...);
> > else if (n->sym->attr.flavor == FL_VARIABLE
> > && !n->sym->as
> > && !n->sym->attr.pointer)
> > gfc_error (...);
> >
>
> Hi Jakub, I've adjusted the patch like you suggested.
>
> Patch has been re-tested and applied to gomp-4_0-branch,
> okay for trunk as well?
Ok with suitable ChangeLog entry.
Jakub