Re: [Trunk/GCC 4.6] Re: [google] Omit date from Fortran .mod files for reproducible builds

[Janne Blomqvist <blomqvist dot janne at gmail dot com>]

On Fri, Sep 16, 2011 at 21:06, Diego Novillo <dnovillo@google.com> wrote:
> On Fri, Jan 28, 2011 at 13:00, Diego Novillo <dnovillo@google.com> wrote:
>> On Fri, Jan 28, 2011 at 06:19, Tobias Burnus <burnus@net-b.de> wrote:
>>> We (Janne and I) think this patch can also be applied to the GCC 4.6 trunk;
>>> as the date is never read there is also no .mod ABI issue.
>>>
>>> I assume that there are no copyright issues.
>>
>> There aren't. ÂGoogle has signed a blanket copyright assignment with
>> the FSF. ÂAny patch coming from a google.com address is covered.
>>
>> I'll mark this patch for trunk. ÂThanks.
>
> Tobias, I'm planning to apply this (old) patch to trunk. ÂStill OK?

Yes, ok.

>
> I've re-bootstrapped on x86_64. ÂNo new failures.
>
>
> Thanks. ÂDiego.
>
> 2011-09-16 ÂSimon Baldwin Â<simonb@google.com>
>
> Â Â Â * module.c (gfc_dump_module): Omit timestamp from output.
>
> diff --git a/gcc/fortran/module.c b/gcc/fortran/module.c
> index 4250a17..b29ba4b 100644
> --- a/gcc/fortran/module.c
> +++ b/gcc/fortran/module.c
> @@ -5178,8 +5178,7 @@ void
> Âgfc_dump_module (const char *name, int dump_flag)
> Â{
> Â int n;
> - Âchar *filename, *filename_tmp, *p;
> - Âtime_t now;
> + Âchar *filename, *filename_tmp;
> Â fpos_t md5_pos;
> Â unsigned char md5_new[16], md5_old[16];
>
> @@ -5221,13 +5220,8 @@ gfc_dump_module (const char *name, int dump_flag)
> Â Â Â Â Â Â Â Â Â Â filename_tmp, xstrerror (errno));
>
> Â /* Write the header, including space reserved for the MD5 sum. Â*/
> - Ânow = time (NULL);
> - Âp = ctime (&now);
> -
> - Â*strchr (p, '\n') = '\0';
> -
> - Âfprintf (module_fp, "GFORTRAN module version '%s' created from %s on %s\n"
> - Â Â Â Â Â"MD5:", MOD_VERSION, gfc_source_file, p);
> + Âfprintf (module_fp, "GFORTRAN module version '%s' created from %s\n"
> + Â Â Â Â Â"MD5:", MOD_VERSION, gfc_source_file);
> Â fgetpos (module_fp, &md5_pos);
> Â fputs ("00000000000000000000000000000000 -- "
> Â Â Â Â"If you edit this, you'll get what you deserve.\n\n", module_fp);
>



-- 
Janne Blomqvist