Re: [ RFC Patch ] Bit Data Structures [GSoC 2019 Conclusion]

[JeanHeyd Meneide <phdofthehouse at gmail dot com>]

Dear libstdc++,

     With <span> in GCC, I was able to add most of the tests from the
public repository into the gcc tests. I also added a few more
slim-include headers to include just bit_iterator, bit_view, or
bit_sequence.

     There are some additional SFINAE constraints that need to be
implemented for <span> to make all the tests work. I locally applied a
patch Jonathan Wakely showed me and ran the tests, and all of them
passed. Without it, 2 fail with excess compilation errors related to
SFINAE not constraining overloads for their constructors based on the
lack of SFINAE in __adl_begin and friends. The fix is to either
implement ranges::begin fully, or to add -> decltype(func(_cont)) to
the __adl_func functions in range_access.h.

Best Wishes,
JeanHeyd

On Mon, Aug 26, 2019 at 2:24 PM JeanHeyd Meneide
<phdofthehouse@gmail.com> wrote:
>
> Dear libstdc++,
>
>      This is the full work for the entirety of Bit Data Structures
> patch for libstdc++. The documentation XML includes benchmarks and
> future work as well as a few implementation notes as well.
>
>      An overview of the final work is here:
> https://thephd.github.io/seize-bits-production-gsoc-2019
>
>      While I am only submitting the patch at the end of GSoC, that by
> no means indicates that I am done contributing to libstdc++. As I
> worked on these bit data structures for libstdc++, I realized there is
> a large portion of functionality I reached for that comes from C++20
> that is missing from libstdc++, including <span> and
> std::ranges::subrange. Since a lot of the 1.5million+ assertions in my
> tests of this bit data structure rely heavily on span and other range
> primitives, I think I will need to implement those for libstdc++ first
> as a precursor to putting in the full test suite (still available
> publicly here: https://github.com/ThePhD/itsy_bitsy/tree/master/tests/run_time/source).
>
>      I look forward to working with the libstdc++ community to slowly
> improve libstdc++ and, eventually, glibc for many years to come. ♥
>
> Cheers,
> JeanHeyd Meneide

Attachment: ThePhD.bit_ds.patch.txt
Description: Text document