This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Adjust std::rotl, std::rotr etc to match final P0553R4 proposal
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 22 Jul 2019 17:58:14 +0100
- Subject: Re: [PATCH] Adjust std::rotl, std::rotr etc to match final P0553R4 proposal
- References: <20190722165510.GA25149@redhat.com>
On 22/07/19 17:55 +0100, Jonathan Wakely wrote:
This proposal has now been accepted for C++20, with a few changes. This
patch adjusts std::rotl and std::rotr to match the final specification
and declares the additions for C++2a mode even when __STRICT_ANSI__ is
defined.
* include/std/bit (__rotl, __rotr): Change second parameter from
unsigned int to int and handle negative values.
(rotl, rotr): Remove check for __STRICT_ANSI__. Change second
parameter from unsigned int to int. Add nodiscard attribute.
* testsuite/26_numerics/bit/bitops.rot/rotl.cc: Rename to ...
* testsuite/26_numerics/bit/bit.rotate/rotl.cc: Here. Test negative
shifts.
* testsuite/26_numerics/bit/bitops.rot/rotr.cc: Rename to ...
* testsuite/26_numerics/bit/bit.rotate/rotr.cc: Here. Test negative
shifts.
This patch applies some more testsuite renaming.
Tested x86_64-linux, committed to trunk.
I'll backport this to gcc-9-branch too.
commit e29d5f9fb11aa5ba05503e66d7d54080ad474be2
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Mon Jul 22 17:57:10 2019 +0100
Rename testsuite directory to match P0553R4 stable names
* testsuite/26_numerics/bit/bitops.count/*: Rename to ...
* testsuite/26_numerics/bit/bit.count/*: Here.
diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countl_one.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.count/countl_one.cc
similarity index 100%
rename from libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countl_one.cc
rename to libstdc++-v3/testsuite/26_numerics/bit/bit.count/countl_one.cc
diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countl_zero.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.count/countl_zero.cc
diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countl_zero.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.count/countl_zero.cc
similarity index 100%
rename from libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countl_zero.cc
rename to libstdc++-v3/testsuite/26_numerics/bit/bit.count/countl_zero.cc
diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countr_one.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.count/countr_one.cc
diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countr_one.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.count/countr_one.cc
similarity index 100%
rename from libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countr_one.cc
rename to libstdc++-v3/testsuite/26_numerics/bit/bit.count/countr_one.cc
diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countr_zero.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.count/countr_zero.cc
diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countr_zero.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.count/countr_zero.cc
similarity index 100%
rename from libstdc++-v3/testsuite/26_numerics/bit/bitops.count/countr_zero.cc
rename to libstdc++-v3/testsuite/26_numerics/bit/bit.count/countr_zero.cc
diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bitops.count/popcount.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.count/popcount.cc