Re: [PATCH] PR libstdc++/71579 assert that type traits are not misused with an incomplete type

[Antony Polukhin <antoshkka at gmail dot com>]

чт, 9 мая 2019 г. в 00:10, Jonathan Wakely <jwakely@redhat.com>:
>
> On 06/05/19 14:19 +0300, Antony Polukhin wrote:
> >@@ -924,14 +984,25 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> >   template<typename _Tp>
> >     struct is_default_constructible
> >     : public __is_default_constructible_safe<_Tp>::type
> >-    { };
> >+    {
> >+      static_assert(std::__is_complete_or_unbounded(__type_identity<_Tp>{}),
> >+      "template argument must be a complete class or an unbounded array");
> >+    };
> >
> >   /// is_constructible
>
> This "///" comment is for Doxygen, and should remain with the
> is_constructible trait, not __is_constructible_impl.

Fixed that issue along with some other misplaced Doxygen comments.
Rebased the patch and removed some trailing white-spaces.

-- 
Best regards,
Antony Polukhin

Attachment: type_traits_hardening.txt
Description: Text document