This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] PR c/79022 fix mismatch parameter order in declaratio
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 28 Mar 2019 14:29:16 +0100
- Subject: Re: [PATCH] PR c/79022 fix mismatch parameter order in declaratio
- References: <20190328132758.GA24504@redhat.com>
On Thu, Mar 28, 2019 at 2:28 PM Jonathan Wakely <jwakely@redhat.com> wrote:
>
> The declaration of create_nested_ptr_option in the header has the 'from'
> and 'to' parameters in the opposite order from the definition in
> gengtype.c:
>
> /* Return an options structure for a "nested_ptr" option. */
> options_p
> create_nested_ptr_option (options_p next, type_p t,
> const char *to, const char *from)
>
> and the only caller in gengtype-parse.c:
>
> return create_nested_ptr_option (prev, ty, to, from);
>
> This patch swaps the parameter names in the declaration.
>
> PR c/79022
> * gengtype.h (create_nested_ptr_option): Fix parameter names to match
> definition.
>
>
> I've rebuilt the compiler, but not run the tests, because this doesn't
> change the meaning of any code and seems almost obvious.
>
> OK for trunk?
OK.
>
>