This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux


On 12/03/19 23:01 +0000, Joseph Myers wrote:
On Mon, 11 Mar 2019, Jonathan Wakely wrote:

+proc add_options_for_libatomic { flags } {
+    if { [istarget hppa*-*-hpux*] } {
+       return "$flags -L../../libatomic/.libs -latomic"
+    }

It's generally inappropriate to hardcode such ../../libatomic/.libs paths
without making sure it's for build-tree rather than installed testing (for
installed testing, -latomic can be found without any -L option and it's
the board file's responsibility to set LD_LIBRARY_PATH if necessary).

I was going to say something about that, but then saw we already do it
for libgomp/.libs as well. Two wrongs now though ...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]