This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits

From: Jonathan Wakely <jwakely at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Sat, 23 Feb 2019 01:27:04 +0000
Subject: Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits
References: <20190223010220.GA32714@redhat.com> <20190223010611.GN7611@tucnak>

On 23/02/19 02:06 +0100, Jakub Jelinek wrote:

On Sat, Feb 23, 2019 at 01:02:20AM +0000, Jonathan Wakely wrote:

	PR libstdc++/89446
	* include/bits/char_traits.h (__constant_char_array): Check index is
	in range before dereferencing.
	* testsuite/21_strings/basic_string_view/operators/char/89446.cc:
	New test.

Tested x86_64-linux, committed to gcc-8-branch and gcc-7-branch.


And not trunk?  The bug is still there, even when it should be usually
ifdefed out because __builtin_is_constexpr_evaluated() should be supported.


Yes, that's a bigger patch (with some cleanup) which is coming
shortly.

Follow-Ups:
- Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits
  - From: Jonathan Wakely

References:
- [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits
  - From: Jonathan Wakely
- Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]