Re: [PATCH] Integration of parallel standard algorithms for c++17

[Thomas Rodgers <trodgers at redhat dot com>]

I will take another stab at un-nit-ing the changlog.

Jakub Jelinek writes:

> On Thu, Jan 31, 2019 at 09:08:52PM -0800, Thomas Rodgers wrote:
>> Update C++17 parallel algorithms to LLVM/MIT licensed upstream sources
>
> Just ChangeLog formatting nits below:
>>
>> 	* include/Makefile.am:update from upstream
>> 		remove ${pstl_srcdir}/iterators.h
>> 		add ${pstl_srcdir}/memory_impl.h
>>
>
> Generally, the format is TAB * SPACE filename optional function name etc. in
> parens COLON SPACE What has changed PERIOD, where what has changed starts
> with a capital letter.  Your entries miss the capital letters, spaces and
> periods.  include/Makefile.am has GCC as its own upstream, so Update from
> upstream. makes no sense.  You've changed something in there, so usually one
> writes what has changed:
> 	* include/Makefile.am (std_headers): Add ${std_srcdir}/execution.
> 	(pstl_srcdir, pstl_builddir, pstl_headers): New variables.
> ...
> etc.
> 	* include/Makefile.in: Regenerated.
>
>> 	* include/bits/c++config:update from upstream
>
> Similarly, c++config doesn't have some other upstream, so one needs to say
> what has changed.  Try contrib/mklog to get a template and just tweak it
> when it doesn't handle something right (it is written mostly for C/C++
> sources, not Makefiles etc.).
>
>> 	* include/pstl/algorithm_fwd.h:update from upstreamgg
>
> etc., these are newly added, so one usually writes ...: New file.

They are newly added yes, but this patch relative to my first version of
this patch where they were newly added. I commented on what changed to
get to this patch.

>
> 	Jakub