This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Relocation (= move+destroy)

From: Jonathan Wakely <jwakely at redhat dot com>
To: Marc Glisse <marc dot glisse at inria dot fr>
Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Date: Sat, 13 Oct 2018 13:13:08 +0100
Subject: Re: Relocation (= move+destroy)
References: <alpine.DEB.2.02.1809011549480.12789@stedding.saclay.inria.fr> <alpine.DEB.2.02.1809012146290.16381@stedding.saclay.inria.fr> <20180902200345.GU4149@redhat.com> <alpine.DEB.2.21.1810131047210.27931@stedding.saclay.inria.fr>

On 13/10/18 11:07 +0200, Marc Glisse wrote:

--- libstdc++-v3/include/bits/alloc_traits.h	(revision 265131)
+++ libstdc++-v3/include/bits/alloc_traits.h	(working copy)
@@ -233,38 +233,43 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
	  using type = decltype(__test<_Alloc>(0));
	};

      template<typename _Tp, typename... _Args>
	using __has_construct
	  = typename __construct_helper<_Tp, _Args...>::type;

      template<typename _Tp, typename... _Args>
	static _Require<__has_construct<_Tp, _Args...>>
	_S_construct(_Alloc& __a, _Tp* __p, _Args&&... __args)
+	noexcept(noexcept(__a.construct(__p, std::forward<_Args>(__args)...)))


You could use std::declval<_Args>()... instead of forwarding __args...
which would be slightly shorter (and might keep some of the others on
a single line). No need to change it unless you want to, either is OK.

I'll finish reviewing the rest on Monday.

Follow-Ups:
- Re: Relocation (= move+destroy)
  - From: Marc Glisse

References:
- Re: Relocation (= move+destroy)
  - From: Marc Glisse

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]