Re: Add <span> Header to libstdc++

[Lars Gullik Bjønnes <larsbj at gullik dot org>]

Not sizeof(span<char, 0> == 1.. that does not fit specification.

On Sun, 7 Oct 2018 at 21:22, Lars Gullik Bjønnes <larsbj@gullik.org> wrote:

> Also getting
>
> sizeof(span<char>) == 16
> sizeof(span<char, 5>) == 8
> sizeof(span<char, 0>) = 1
>
> would be nice. (x86_64)
>
>
> On Tue, 2 Oct 2018 at 01:26, Ed Smith-Rowland <3dw4rd@verizon.net> wrote:
>
>> Conor,
>>
>> I am CCing the libstdc++ list to get more eyes on this.  We send
>> libstdc++ patches to both libstdc++ and gcc-patches.
>>
>> Do you have Copyright assignment to the FSF?  You'll want to start hat
>> quickly if you don't have it.
>>
>> I am looking over your patch for <span> and it looks like a good start.
>>
>> For the main patch there are mostly style issues (see
>> gcc.gnu.org/onlinedocs/libstdc++//manual/source_code_style.html)
>>
>> The biggest thing might be the testsuite.  You'll want a
>> libstdc++-v3/testsuite/23_containers/span directory.  Look in the
>> sibling directories for how these things are structured.
>>
>> Best regards,
>>
>> Ed Smith-Rowland
>>
>> OP: https://gcc.gnu.org/ml/gcc-patches/2018-09/msg01658.html
>>
>>
>>
>
> --
>         Lgb
>


-- 
        Lgb