This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] PR libstdc++/86169 unshare COW string when non-const data() called

From: Jonathan Wakely <jwakely at redhat dot com>
To: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Fri, 15 Jun 2018 19:47:18 +0100
Subject: [PATCH] PR libstdc++/86169 unshare COW string when non-const data() called

When I added the non-const basic_string::data() overload I made a
silly mistake in the COW version, failing to "leak" the string (i.e.
unshare it and return a pointer to a uniquely-owned string).

	PR libstdc++/86169
	* include/bits/basic_string.h [!_GLIBCXX_USE_CXX11_ABI]
	(basic_string::data()): Unshare string.
	* testsuite/21_strings/basic_string/operations/data/char/86169.cc:
	New.

Tested powerpc64le-linux, committed to trunk. Backports to 7 and 8
coming soon.

Attachment: patch.txt
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]