This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Ed Smith-Rowland <3dw4rd at verizon dot net>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jonathan Wakely <jwakely dot gcc at gmail dot com>, redi at gcc dot gnu dot org
- Date: Fri, 17 Nov 2017 20:54:29 +0000
- Subject: Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values
- Authentication-results: sourceware.org; auth=none
- References: <755dc780-d676-65ca-ba9b-81a4bf80a3f3@verizon.net>
On 17/11/17 15:05 -0500, Ed Smith-Rowland wrote:
This is an embarrassment actually, after the excellent analysis in the
PR trail.
We've (I've) been using the wrong sign convention for the nu parameter
in comp_ellint_3 and in ellint_3 in tr1 and now std for years. In my
defence the World seems about evenly split on this with GSL,
Abramowitz&Stegun (and DLMF) and Carlson (that's what actually got me
here) on the +nu side, and tr1/std, boost on the other -nu side.
We need to get this into 8.
I'm not sure about backporting to 7. I don't think we should change
this breaking in the middle of a release series.
Hmm, you're probably right. I'd be tempted to though.
I'll write a Mea Culpa warning about changing ellint_3, comp_ellint_3
in the release notes and in the libstdc++ pages and the tr29124
conformance page later.
This builds and passes on x86-64-linux.
OK for 8?
OK, thanks.