This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [libstdc++-v3] Add configure check for S_ISSOCK

From: Andris Pavenis <andris dot pavenis at iki dot fi>
To: Jonathan Wakely <jwakely at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org, DJ Delorie <dj at delorie dot com>
Date: Tue, 7 Nov 2017 21:00:46 +0200
Subject: Re: [libstdc++-v3] Add configure check for S_ISSOCK
Authentication-results: sourceware.org; auth=none
References: <bf50830b-939a-6acf-80f8-d27ccd8df3d5@iki.fi> <20171107182820.GD3526@redhat.com>

On 11/07/2017 08:28 PM, Jonathan Wakely wrote:

On 07/11/17 19:26 +0200, Andris Pavenis wrote:

src/filesystem/ops-common.c uses S_ISSOCK unconditionally without checking that it is available

As result compile fails for DJGPP when S_ISREG is available but S_ISSOCK is not. Included patchadd configure check for S_ISSOCK


Andris

ChangeLog entry:

2017-11-07  Andris Pavenis<andris.pavenis.iki.fi>

    * acinclude.m4 (GLIBCXX_CHECK_S_ISSOCK): Define
    * configure.ac: Check presence of S_ISSOCK
    * src/filesystem/ops-common.h: Only use S_ISSOCK if defined for target
    * config.h.in: Regenerate
    * configure: Regenerate


Do we need an autoconf check?

I just followed the same style as with S_ISREG/S_IFREG...

Simple #ifdef S_ISSOCK is sufficient in this case.

Andris

Follow-Ups:
- Re: [libstdc++-v3] Add configure check for S_ISSOCK
  - From: Jonathan Wakely

References:
- [libstdc++-v3] Add configure check for S_ISSOCK
  - From: Andris Pavenis
- Re: [libstdc++-v3] Add configure check for S_ISSOCK
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]