This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] streambuf_iterator: avoid debug-dependent behaviour

From: François Dumont <frs dot dumont at gmail dot com>
To: Petr Ovtchenkov <ptr at void-ptr dot info>
Cc: libstdc++ at gcc dot gnu dot org
Date: Fri, 8 Sep 2017 08:15:03 +0200
Subject: Re: [PATCH] streambuf_iterator: avoid debug-dependent behaviour
Authentication-results: sourceware.org; auth=none
References: <E1dkqHr-0008T4-Qa@void-ptr.info> <20170901091037.GW4582@redhat.com> <86fe822c-96c0-1167-68d9-d79729f3dec5@gmail.com> <20170908084740.5afaeae3@void-ptr.info>

On 08/09/2017 07:47, Petr Ovtchenkov wrote:

-gcc-patches

On Thu, 7 Sep 2017 23:02:15 +0200
François Dumont <frs.dumont@gmail.com> wrote:

+	_M_c = _M_sbuf->sgetc();
+	if (_S_at_eof(_M_c))
+	  _M_sbuf = 0;

_M_sbuf = 0; <--- Is not what I expect here.


I know but I didn't say that I agree with all your patch.

I only agree with your remark about current implementation beingdebug-dependant which I have been able to prove with a test case at thecost of a small change in the current implementation to fix another problem.

References:
- Re: [PATCH] streambuf_iterator: avoid debug-dependent behaviour
  - From: Jonathan Wakely
- Re: [PATCH] streambuf_iterator: avoid debug-dependent behaviour
  - From: François Dumont
- Re: [PATCH] streambuf_iterator: avoid debug-dependent behaviour
  - From: Petr Ovtchenkov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]