This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Fix typo in std::stack (PR libstdc++/81599)
- From: Marek Polacek <polacek at redhat dot com>
- To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 31 Jul 2017 15:42:25 +0200
- Subject: Re: [PATCH] Fix typo in std::stack (PR libstdc++/81599)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=polacek at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C05E011A264
- References: <20170731132559.GP3397@redhat.com> <CAFk2RUbTiOxV1JCaH1uaDJu6DeZw5bYZLM_UurDTvjV9R+b2aw@mail.gmail.com>
On Mon, Jul 31, 2017 at 04:37:19PM +0300, Ville Voutilainen wrote:
> On 31 July 2017 at 16:25, Marek Polacek <polacek@redhat.com> wrote:
> > The documentation of std::stack says that the underlying container must support
> > pop_front, but that is wrong, it meant to say pop_back, so this patch fixes
> > that.
>
> Indeed, the documentation has a copy-pasto originating from bits/stl_queue.h.
>
> > Ok for trunk?
>
>
> I can't approve the patch, but I suggest committing it as obvious.
Yea, will do. Thanks,
Marek