This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Fix a C++ crash with may_alias type attribute
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Cc: Jonathan Wakely <jwakely at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Wed, 5 Apr 2017 02:34:05 +0000
- Subject: Re: [PATCH] Fix a C++ crash with may_alias type attribute
- Authentication-results: sourceware.org; auth=none
- Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=hotmail.de;
- References: <AM4PR0701MB216224552289BEFFCD2B1A12E40B0@AM4PR0701MB2162.eurprd07.prod.outlook.com> <20170404125843.GP4425@redhat.com> <AM4PR0701MB2162496C5F59CCB971225B63E40B0@AM4PR0701MB2162.eurprd07.prod.outlook.com> <CAFk2RUb__Pys83PyPQ0_Y=8RaZSV9wx-G9qShiugA36cNOTL9w@mail.gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 04/05/17 00:33, Ville Voutilainen wrote:
> On 5 April 2017 at 00:29, Bernd Edlinger <bernd.edlinger@hotmail.de> wrote:
>>> The new test doesn't really belong in the libstdc++, does it?
>>>
>>> If this is a bug in the front-end then a reduced version of the test
>>> belongs in the g++ testsuite.
>>>
>>
>> Yes, I moved the test case to the g++.dg/lto branch, where it
>> fortunately also works (I forgot to mention that the crash only
>> happened with -flto).
>>
>> Is it Ok for trunk?
>
>
> That's not a reduced test. You need to remove dependencies to library
> facilities.
>
I replaced the dependency to VERIFY and used a own macro,
and verified, that the test still produce the error.
It is IMHO not worth to invest more time than this in a test
for an already obvious bug-fix.
Bernd.