Re: [v3 PATCH] Implement std::is_aggregate.

[Ville Voutilainen <ville dot voutilainen at gmail dot com>]

On 2 April 2017 at 14:08, Jakub Jelinek <jakub@redhat.com> wrote:
> On Sun, Apr 02, 2017 at 12:24:16PM +0300, Ville Voutilainen wrote:
>> On 2 April 2017 at 08:35, Jakub Jelinek <jakub@redhat.com> wrote:
>> >> +      remove_cv_t<_Tp>
>> >> +      )>
>> >
>> > Any reason for the wrapping?
>>
>> No, it's just a result of a nocturnal copy-paste-job of the existing
>> code for has_unique_object_representations.
>>
>> > Also, shouldn't there be also:
>> >
>> >   /// is_aggregate_v
>> >   template<typename _Tp>
>> >     _GLIBCXX17_INLINE constexpr bool is_aggregate_v =
>> >       is_aggregate<_Tp>::value;
>> >
>> > somewhere with appropriate guards (or within the same ones)?
>>
>> Yes, well spotted. I will add that.

Thus:

2017-04-02  Ville Voutilainen  <ville.voutilainen@gmail.com>

    Implement std::is_aggregate.
    * include/std/type_traits (is_aggregate, is_aggregate_v): New.
    * testsuite/20_util/is_aggregate/requirements/explicit_instantiation.cc:
    New.
    * testsuite/20_util/is_aggregate/requirements/typedefs.cc: Likewise.
    * testsuite/20_util/is_aggregate/value.cc: Likewise.

Attachment: is_aggregate_2.diff
Description: Text document