This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR67085 move comparison functions in heap operations

From: Jonathan Wakely <jwakely at redhat dot com>
To: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Thu, 19 Jan 2017 18:50:10 +0000
Subject: Re: [PATCH] PR67085 move comparison functions in heap operations
Authentication-results: sourceware.org; auth=none
References: <20170119182838.GA19767@redhat.com>

On 19/01/17 18:28 +0000, Jonathan Wakely wrote:

@@ -397,7 +401,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
      while (__last - __first > 1)
	{
	  --__last;
-	  std::__pop_heap(__first, __last, __last, __comp);
+	  std::__pop_heap(__first, __last, __last, _GLIBCXX_MOVE(__comp));


Oops, we can't move from the functor in a loop, it might be invalid
after the first move. Fix coming asap.

Follow-Ups:
- Re: [PATCH] PR67085 move comparison functions in heap operations
  - From: Jonathan Wakely

References:
- [PATCH] PR67085 move comparison functions in heap operations
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]