This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3 PATCH] PR libstdc++/78389
- From: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- To: Tim Song <t dot canens dot cpp at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Sun, 15 Jan 2017 19:01:02 +0200
- Subject: Re: [v3 PATCH] PR libstdc++/78389
- Authentication-results: sourceware.org; auth=none
- References: <CAFk2RUYjjXW2MGuEaLRPHV87R7YB-PTYhSk7QnxzJUBdHS4nkA@mail.gmail.com> <CAPQZVxvKSeaboXFC=W722L+M9W1fMW2v7Q3dZnfjfTYsxJmNhQ@mail.gmail.com>
On 15 January 2017 at 18:42, Tim Song <t.canens.cpp@gmail.com> wrote:
> On rereading the patch today, the size calculation for merge() appears
> to be backwards. [__first2, __last2) consists of the nodes not
> transferred into *this, so the new size of __x should be __dist while
> this->size() should be incremented by (__orig_size - __dist).
Ah, yes, I'm an idiot. Fixing...