This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, testsuite]: Fix detection of -j make argument

From: Jonathan Wakely <jwakely at redhat dot com>
To: libstdc++ at gcc dot gnu dot org
Cc: Uros Bizjak <ubizjak at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Eric Botcazou <ebotcazou at adacore dot com>
Date: Tue, 22 Nov 2016 16:21:50 +0000
Subject: Re: [PATCH, testsuite]: Fix detection of -j make argument
Authentication-results: sourceware.org; auth=none
References: <CAFULd4bk9HLkQtAqkOtVpyHwUuJCjb7y43EsX54szSP048x6sw@mail.gmail.com> <alpine.DEB.2.20.1611221653030.2413@laptop-mg.saclay.inria.fr>

On 22/11/16 16:54 +0100, Marc Glisse wrote:

On Tue, 22 Nov 2016, Uros Bizjak wrote:

New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a
different way. While older makes pass only "-j", newer makes pass e.g.
"-j4" when -j is specified on the command line. The detection of "-j"
make argument doesn't work in the later case.

Attached patch reworks this functionality to detect -j correctly in all cases.


Hello,

I didn't read the patch, but do you think this also fixes PR 53155 ?


No, probably not, as it only changes the "-j N" case, not the "-j"
case in your PR, which doesn't match because the -j gets combined with
other make flags.

References:
- [PATCH, testsuite]: Fix detection of -j make argument
  - From: Uros Bizjak
- Re: [PATCH, testsuite]: Fix detection of -j make argument
  - From: Marc Glisse

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]