This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [v3 PATCH] Make any's copy assignment operator exception-safe, don't copy the underlying value when any is moved, make in_place constructors explicit.

From: Jonathan Wakely <jwakely at redhat dot com>
To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 10 Oct 2016 23:01:53 +0100
Subject: Re: [v3 PATCH] Make any's copy assignment operator exception-safe, don't copy the underlying value when any is moved, make in_place constructors explicit.
Authentication-results: sourceware.org; auth=none
References: <CAFk2RUbLLWTsMdo-ZMbJorAwmcSauhgLK2mYZypzmeZbLqeDkw@mail.gmail.com> <20161010181957.GA31033@redhat.com> <CAFk2RUZ6a0d-BRLY1BSSbu-83Omxm28oLQmdfJ6H9dTV3FvnQQ@mail.gmail.com>

On 10/10/16 22:21 +0300, Ville Voutilainen wrote:

This code was all pretty carefully written to avoid any redundant
operations. Does this change buy us anything except simpler code?


As discussed, destroying the value but leaving the manager non-null will
do bad things.


Oops again on my part! Not so carefully written, or tested.

New patch attached, ok for trunk?


OK, thanks.

References:
- [v3 PATCH] Make any's copy assignment operator exception-safe, don't copy the underlying value when any is moved, make in_place constructors explicit.
  - From: Ville Voutilainen
- Re: [v3 PATCH] Make any's copy assignment operator exception-safe, don't copy the underlying value when any is moved, make in_place constructors explicit.
  - From: Jonathan Wakely
- Re: [v3 PATCH] Make any's copy assignment operator exception-safe, don't copy the underlying value when any is moved, make in_place constructors explicit.
  - From: Ville Voutilainen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]