This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Remove use of std::abs in experimental::{gcd,lcm}

From: Jonathan Wakely <jwakely at redhat dot com>
To: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Fri, 30 Sep 2016 14:43:31 +0100
Subject: [PATCH] Remove use of std::abs in experimental::{gcd,lcm}
Authentication-results: sourceware.org; auth=none

std::abs isn't suitable for these functions because we need something
that works in constexpr functions and with unsigned types.

Also, <experimental/numeric> is supposed to include <numeric>.

	PR libstdc++/77801
	* include/experimental/numeric: Include <numeric>.
	(__abs): Define.
	(gcd, lcm): Use __abs instead of std::abs.
	* testsuite/experimental/numeric/77801.cc: New test.
	* testsuite/experimental/numeric/gcd.cc: Test unsigned inputs.
	* testsuite/experimental/numeric/lcm.cc: Likewise.

Tested powerpc64le-linux, committed to trunk. Backport to gcc-6
coming too.

Attachment: patch.txt
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]