Re: [libstdc++-v3] Fix dg-require before dg-run directives in testsuite.

[Christophe Lyon <christophe dot lyon at linaro dot org>]

On 6 September 2016 at 12:15, Jonathan Wakely <jwakely@redhat.com> wrote:
> On 02/09/16 14:17 +0100, Matthew Wahab wrote:
>>
>> Hello,
>>
>> Tests in the libstdc++-v3 testsuite were recently changed to use { dg-do
>> .. { target c++11 } } instead of using a dg-options to set -std
>> (https://gcc.gnu.org/ml/libstdc++/2016-08/msg00102.html). As a
>> consequence, several tests were left with directive lists that had
>> dg-require preceding dg-do. This meant that some tests were run when
>> they should have been skipped as unsupported. In particular, most of the
>> 23_algorithms/*/complexity.cc tests became FAIL on aarch64-none-elf
>>
>> This patch adjusts the tests so that the dg-requires come after the
>> dg-do directives. The makes the tests that were previously
>> FAIL/UNRESOLVED become UNSUPPORTED. It also makes UNSUPPORTED some tests
>> that were PASS.
>>
>> The tests that move from FAIL/UNRESOLVED to UNSUPPORTED:
>>
>> - 22_locale/locale/cons/unicode.cc.
>> - 25_algorithms/{pop_heap,push_heap,sort_heap}/complexity.c.
>>
>> From PASS to UNSUPPORTED:
>>
>> - 23_containers/*/debug/60499.c
>> - 23_containers/vector/debug/52433.c
>>
>> Tested by running the testsuite for cross-compiled aarch64-none-elf.
>>
>> Ok for trunk?
>
>
> Yes, thanks for cleaning this up.
>
>
Hello,

It seems some tests still have dg-require or dg-skip before dg-do.
The attached patch fixes that, the only effect is that
25_algorithms/lower_bound/debug/irreflexive.cc
is now UNSUPPORTED instead of PASS on arm* and aarch64* targets.

I'm not sure if that's expected. I do see: "#error No debug mode" in the logs.

OK for trunk?

Thanks,

Christophe

Attachment: fix-dg.log.txt
Description: Text document

Attachment: fix-dg.patch.txt
Description: Text document