This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Implement is_[nothrow_]swappable (p0185r1)
- From: Mike Stump <mikestump at comcast dot net>
- To: Daniel KrÃgler <daniel dot kruegler at gmail dot com>
- Cc: Jonathan Wakely <jwakely at redhat dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 25 May 2016 12:36:51 -0700
- Subject: Re: [Patch] Implement is_[nothrow_]swappable (p0185r1)
- Authentication-results: sourceware.org; auth=none
- References: <CAGNvRgAChC7WZY0iKhVmzqdj=2waeWPqtC8YpmWrxGNRdKsucw at mail dot gmail dot com> <20160523115015 dot GE2789 at redhat dot com> <CAGNvRgD=OFhne_HtkgNNLhbVzzf4HKOTqFmr3nkCfJeFWYV3zA at mail dot gmail dot com>
On May 24, 2016, at 9:50 PM, Daniel KrÃgler <daniel.kruegler@gmail.com> wrote:
>
> 2016-05-23 13:50 GMT+02:00 Jonathan Wakely <jwakely@redhat.com>:
>> On 17/05/16 20:39 +0200, Daniel KrÃgler wrote:
>>>
>>> This is an implementation of the Standard is_swappable traits according to
>>>
>>> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0185r1.html
>>>
>>> During that work it has been found that std::array's member swap's
>>> exception
>>> specification for zero-size arrays was incorrectly depending on the
>>> value_type
>>> and that was fixed as well.
>>
>> This looks good to me, I'll get it committed (with some adjustment to
>> the ChangeLog format) - thanks.
>
> Unfortunately I need to withdraw the suggested patch. Besides some
> obvious errors there are issues that require me to get the testsuite
> run on my Windows system, which had not yet succeeded.
>
> I would appreciate, if anyone who has succeeded to run the test suite
> on a Windows system (preferably mingw), could contact me off-list.
So, you can fix up the code that matters, and re-post the that code, and merely say the patch doesn't have testing on it and ask others to run the test suite for you. Once you hear back and that the patch tests out well, you can then seek approval for inclusion, even though you never tested it. Longer term, it is handy to be able to run the test suite yourself... If Windows proves to be a pain, you you can run a VM with linux on it, and then run the test suite in the linux VM on windows. Also, you can grab cygwin, testing there should be very, very close to just install cygwin, make && make check.