This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] libstdc++/69703 ignore endianness in codecvt_utf8
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: "Andre Vieira (lists)" <Andre dot SimoesDiasVieira at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Thu, 5 May 2016 11:12:25 +0100
- Subject: Re: [patch] libstdc++/69703 ignore endianness in codecvt_utf8
- Authentication-results: sourceware.org; auth=none
- References: <20160419180305 dot GB3577 at redhat dot com> <20160419180629 dot GC3577 at redhat dot com> <20160419180749 dot GD3577 at redhat dot com> <20160420174028 dot GK3577 at redhat dot com> <572A20FC dot 7080702 at arm dot com>
On 04/05/16 17:19 +0100, Andre Vieira (lists) wrote:
On 20/04/16 18:40, Jonathan Wakely wrote:
On 19/04/16 19:07 +0100, Jonathan Wakely wrote:
This was reported as a bug in the Filesystem library, but it's
actually a problem in the codecvt_utf8 facet that it uses.
The fix had a silly typo meaning it didn't work for big endian
targets, which was revealed by the improved tests I added.
Tested x86_64-linux and powerpc64-linux, committed to trunk.
Hi Jonathan,
We are seeing experimental/filesystem/path/native/string.cc fail on
baremetal targets. I'm guessing this is missing a
'dg-require-filesystem-ts', as seen on other tests like
experimental/filesystem/path/modifiers/swap.cc.
Cheers,
Andre
Sorry about that, I've committed the missing directive.
commit 775381d7e53d5a68a2725b6b72f081d254d9380b
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu May 5 10:42:35 2016 +0100
Add dg-require-filesystem-ts directive to test
* testsuite/experimental/filesystem/path/native/string.cc: Add
dg-require-filesystem-ts directive.
diff --git a/libstdc++-v3/testsuite/experimental/filesystem/path/native/string.cc b/libstdc++-v3/testsuite/experimental/filesystem/path/native/string.cc
index 05ff57c..e56fda7 100644
--- a/libstdc++-v3/testsuite/experimental/filesystem/path/native/string.cc
+++ b/libstdc++-v3/testsuite/experimental/filesystem/path/native/string.cc
@@ -16,6 +16,7 @@
// <http://www.gnu.org/licenses/>.
// { dg-options "-std=gnu++11 -lstdc++fs" }
+// { dg-require-filesystem-ts "" }
#include <experimental/filesystem>
#include <string>