This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch, regex, libstdc++/69794] Unify special character parsing
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Tim Shen <timshen at google dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 15 Feb 2016 12:26:39 +0000
- Subject: Re: [Patch, regex, libstdc++/69794] Unify special character parsing
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNkXopFFMFXegf_2h8U9c6+3Zx_-CQ-0dm1+k6onnOb1eA at mail dot gmail dot com>
On 13/02/16 11:13 -0800, Tim Shen wrote:
I did it wrong in r227289 - I ignored the "\n" special case in grep.
Turns out using code to handle special cases is error prone, so I
turned to use data (_M_grep_spec_char and _M_egrep_spec_char).
Those new members change the size of the type, so are an ABI change.
Couldn't they be static members?